[Core][Distributed] enable multiple tp group #4512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adding... |
|
ok node is up, try setting num_gpus to 4 in the pipeline yaml? |
Only run this test in 4 gpu machine, or run all distributed tests in 4 gpu machine? |
16 tasks
|
TODO: we can also use 4 GPU node to test pipeline parallel and multi-node setup, by using two docker containers with 2 GPUs each. |
zhuohan123
approved these changes
May 1, 2024
zhuohan123
reviewed
May 1, 2024
Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
This was referenced May 2, 2024
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
May 6, 2024
Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
May 7, 2024
Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
May 7, 2024
Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
mawong-amd
pushed a commit
to ROCm/vllm
that referenced
this pull request
Jun 3, 2024
Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the code to support multiple groups. An ongoing effort to support pipeline parallel #4412 in the end.
cc @simon-mo when we have 4 GPU CI machines ready, tests in this PR can be merged. I tested it locally, and it works.