[CI] Reduce wheel size by not shipping debug symbols #4602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size built within docker container is <100MB. But the wheels generated by github action runner is >100MB 
I will continue work on #4299 but it might take some time.... |
robertgshaw2-neuralmagic
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
May 6, 2024
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
May 7, 2024
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
May 7, 2024
This was referenced May 15, 2024
mawong-amd
pushed a commit
to ROCm/vllm
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #3792, we cannot ship wheels greater than 100MB in size. However, the latest wheel build from v0.4.2 8d8357c generated wheel is 103MB. This is pretty strange as my locally built wheel with the same environment generated wheel of size 97MB. The two wheels have exactly the same set of kernels for same set of
sms.Rather than comparing the binaries, I found if debug info is stripped, the wheel size can be greatly reduced. Therefore, until we figure out other approaches to reduce the debug info for the wheel build, the PyPI packages will live without debug symbols 馃槩