[Fix] Fix GPTBigcoder for distributed execution #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WoosukKwon This PR is ready to review! |
WoosukKwon
approved these changes
Jul 25, 2023
Comment on lines
+326
to
+334
| if name == "transformer.wte.weight": | ||
| # Consider padding in the vocab size. | ||
| padded_vocab_size = param.shape[ | ||
| 0] * tensor_model_parallel_world_size | ||
| num_extra_rows = padded_vocab_size - self.config.vocab_size | ||
| extra_rows = torch.empty(num_extra_rows, | ||
| loaded_weight.shape[1]) | ||
| extra_rows = extra_rows.to(loaded_weight) | ||
| loaded_weight = torch.cat([loaded_weight, extra_rows], dim=0) |
There was a problem hiding this comment.
Maybe not in this PR, but I think we can refactor this out, as it is used in multiple models.
There was a problem hiding this comment.
Sounds good! I think that makes a lot of sense. Also, the attention weights loading part can be refactored.
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
sjchoi1
pushed a commit
to casys-kaist-internal/vllm
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #488 and #487