Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPTJConfig has no attribute rotary. #532

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

leegohi04517
Copy link
Contributor

GPTJConfig has no attribute rotary. Remove this line to skip runtime error when using gpt-j model.

Copy link
Collaborator

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for proposing the fix! Use getattr to check the model with the field rotary

@zhuohan123 zhuohan123 merged commit 1dde34e into vllm-project:main Jul 24, 2023
2 checks passed
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
sjchoi1 pushed a commit to casys-kaist-internal/vllm that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants