[Fix] Add chat completion Example and simplify dependencies #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoosukKwon
approved these changes
Jul 26, 2023
examples/openai_client.py
Outdated
Comment on lines
30
to
50
| # Chat completion API | ||
| chat_completion = openai.ChatCompletion.create( | ||
| model=model, | ||
| messages=[{ | ||
| "role": "system", | ||
| "content": "You are a helpful assistant." | ||
| }, { | ||
| "role": "user", | ||
| "content": "Who won the world series in 2020?" | ||
| }, { | ||
| "role": | ||
| "assistant", | ||
| "content": | ||
| "The Los Angeles Dodgers won the World Series in 2020." | ||
| }, { | ||
| "role": "user", | ||
| "content": "Where was it played?" | ||
| }]) | ||
|
|
||
| print("Chat completion results:") | ||
| print(chat_completion) |
There was a problem hiding this comment.
A quick question: why don't we have this in a separate file (say openai_chat_client.py)?
There was a problem hiding this comment.
No special reason at the beginning. Let me move it to another file then.
| @@ -63,6 +67,9 @@ async def check_model(request) -> Optional[JSONResponse]: | |||
|
|
|||
|
|
|||
| async def get_gen_prompt(request) -> str: | |||
| assert _fastchat_available, ( | |||
There was a problem hiding this comment.
nit: As this is user-facing error, I feel raising error is a bit more appropriate.
assert is used to ensure internal correctness, not to enforce correct usage nor to indicate that some unexpected event occurred. If an exception is desired in the latter cases, use a raise statement.
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
sjchoi1
pushed a commit
to casys-kaist-internal/vllm
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #545 #537
Make fastchat an optional dependency giving the huge dependency list of fastchat and many complaints on installation.