Add Falcon support (new) #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuohan123
force-pushed
the
falcon-zhuohan
branch
from
b492519
to
bc7514e
Compare
|
@WoosukKwon This PR is ready for review. |
WoosukKwon
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
@zhuohan123 Awesome! Thanks a million for this hard work! Left minor comments.
|
This PR seems lead wrong outputs to BigCoder models when TP=2. |
sjchoi1
pushed a commit
to casys-kaist-internal/vllm
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #195 #197 #356
This PR replaces PR #321
Also, revert an early all-reduce optimization that stores all all-reduce results in a shared buffer. This can lead to wrong results in distributed settings for models with two parallel all-reduce branches.
Correctness check: