fix biachuan-7b tp #598
Merged
fix biachuan-7b tp #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the same reason for baichuan-13b? #530 |
Yes. I have tested it on both baichuan13b and 7b, and it can output normal output under tp. |
Can I use this PR directly on 13B？ |
zhuohan123
requested changes
Jul 30, 2023
Comment on lines
282
to
294
| if "embed_tokens" in name or "lm_head" in name: | ||
| # Consider padding in the vocab size. | ||
| param = state_dict[name] | ||
| padded_vocab_size = param.shape[0] * tp_world_size | ||
| num_extra_rows = padded_vocab_size - self.config.vocab_size | ||
| extra_rows = torch.empty(num_extra_rows, loaded_weight.shape[1]) | ||
| extra_rows = extra_rows.to(loaded_weight) | ||
| loaded_weight = torch.cat([loaded_weight, extra_rows], dim=0) | ||
|
|
||
| if "W_pack" in name: | ||
| # W_pack.weight.shape [3*hidden_size, hidden_size] [3*4096, 4096] = [12,288, 4096] | ||
| total_num_heads = self.config.num_attention_heads | ||
| hidden_size = self.config.hidden_size | ||
| head_size = hidden_size // total_num_heads | ||
| num_heads = total_num_heads // tp_world_size | ||
| head_start = tp_rank * num_heads | ||
| head_end = (tp_rank + 1) * num_heads | ||
|
|
||
| loaded_weight = loaded_weight.view( | ||
| 3, total_num_heads, head_size, hidden_size | ||
| ) | ||
| loaded_weight = loaded_weight[:, head_start:head_end, :, :] | ||
| loaded_weight = loaded_weight.reshape(-1, hidden_size) | ||
|
|
There was a problem hiding this comment.
Is this part the only part that actually changes the code logic? Can you remove other format-only modifications and use format.sh script provided by us to re-format the code? Thanks!
There was a problem hiding this comment.
Hi, I have already modified the content of the PR and removed the invalid format part.
Sanster
force-pushed
the
fix_baichuan_7b_tp
branch
from
356793c
to
aeb2d9e
Compare
zhuohan123
approved these changes
Aug 1, 2023
This was referenced Aug 7, 2023
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Co-authored-by: wq.chu <wq.chu@tianrang-inc.com>
sjchoi1
pushed a commit
to casys-kaist-internal/vllm
that referenced
this pull request
May 7, 2024
Co-authored-by: wq.chu <wq.chu@tianrang-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main modifications are in the "load_weights" function.
Before:
After:
