fix ModuleNotFoundError #599
Merged
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuohan123
approved these changes
Jul 28, 2023
vllm/engine/llm_engine.py
Outdated
| @@ -14,6 +14,7 @@ | |||
| from vllm.transformers_utils.tokenizer import (detokenize_incrementally, | |||
| get_tokenizer) | |||
| from vllm.utils import Counter | |||
| import copy | |||
There was a problem hiding this comment.
Nit: maybe move this copy to the beginning of this file?
There was a problem hiding this comment.
ok, I updated the code
move import copy to file start
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Co-authored-by: fangli <fangli@tencent.com>
sjchoi1
pushed a commit
to casys-kaist-internal/vllm
that referenced
this pull request
May 7, 2024
Co-authored-by: fangli <fangli@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr is related to issue #572
as stated in this issue, the error originates from the capture of self object, but only 3 config is needed.