[Model] support baichuan-13b based on baichuan-7b #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Oliver-ss
commented
Aug 2, 2023
Oliver-ss
commented
- baichuan-7b and baichuan-13b have different architectures in config.json, "BaichuanForCausalLM" for baichuan-13b and "BaiChuanForCausalLM" for baichuan-7b.
- The model structures are almost the same except for position embedding. (RoPE for baichuan-7b and Alibi for baichuan-13b.) So most of the code coule be shared.
zhuohan123
approved these changes
Aug 2, 2023
This was referenced Aug 2, 2023
Closed
|
@zhuohan123 So this resolved baichuan13b tp issue? But I think there was another PR merged in before, which one to use? |
This was referenced Aug 2, 2023
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
sjchoi1
pushed a commit
to casys-kaist-internal/vllm
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.