[BUG FIX] upgrade fschat version to 0.2.23 #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuohan123
approved these changes
Aug 2, 2023
| @@ -72,10 +73,17 @@ async def get_gen_prompt(request) -> str: | |||
| "fastchat is not installed. Please install fastchat to use " | |||
| "the chat completion and conversation APIs: `$ pip install fschat`" | |||
| ) | |||
| if fastchat.__version__ < "0.2.23": | |||
There was a problem hiding this comment.
Can you compare the version using a more robust library? Example: https://stackoverflow.com/a/11887885
YHPeter
changed the title
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Co-authored-by: hao.yu <hao.yu@cn-c017.server.mila.quebec>
sjchoi1
pushed a commit
to casys-kaist-internal/vllm
that referenced
this pull request
May 7, 2024
Co-authored-by: hao.yu <hao.yu@cn-c017.server.mila.quebec>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr ignored the L95 need to change.