Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Makefile.am.libasn1codec compatible with non-recursive Makef… #243

Closed
wants to merge 1 commit into from

Conversation

ringlej
Copy link
Contributor

@ringlej ringlej commented Nov 13, 2017

…ile.am

The fact that the existing code creates files with names like:
Makefile.am.libasncodec
Makefile.am.example

leads me to believe that there is an attempt to create automake compatible
Makefile.am files. However, there are some things that are wrong with the
example generated files. For example, ASN_MODULES_SOURCES variable can't
be used because all *_SOURCES variables are expected to be either a
bin_PROGRAM or lib_LTLIBRARIES, and of course, there is neither:
bin_PROGRAMS += ASN_MODULES
or
lib_LTLIBRARIES += ASN_MODULES

This patch does the following:

  1. correct the invalid variable names for use with autotools
  2. cleanly separate the library generation from an example as1convert prog
  3. Add a new option -D that will write the generated files to the
    specified directory, and the generated Makefile.am.* will be compatible
    with a non-recursive Makefile.am schema
  4. Add a new option -gen-autotools which will create (if they don't exist) a minimal
    example configure.ac and Makefile.am

This will make it much easier to integrate the generated asn1 source files with a larger project

…ile.am

The fact that the existing code creates files with names like:
  Makefile.am.libasncodec
  Makefile.am.example

leads me to believe that there is an attempt to create automake compatible
Makefile.am files. However, there are some things that are wrong with the
example generated files. For example, ASN_MODULES_SOURCES variable can't
be used because all *_SOURCES variables are expected to be either a
bin_PROGRAM or lib_LTLIBRARIES, and of course, there is neither:
  bin_PROGRAMS += ASN_MODULES
or
  lib_LTLIBRARIES += ASN_MODULES

This patch does the following:
1) correct the invalid variable names for use with autotools
2) cleanly separate the library generation from an example as1convert prog
3) Add a new option -D <destdir> that will write the generated files to the
   specified directory, and the generated Makefile.am.* will be compatible
   with a non-recursive Makefile.am schema
4) Add a new option -gen-autotools which will create (if they don't exist) a minimal
   example configure.ac and Makefile.am
@ringlej
Copy link
Contributor Author

ringlej commented Nov 14, 2017

It's clear to me now that this patch won't do in it's current form for the unit tests. I will work on this and send another PR

@ringlej ringlej closed this Nov 14, 2017
@vlm
Copy link
Owner

vlm commented Nov 14, 2017

@ringlej sounds good. Prefer to send separate self-contained PRs. Such as, the -gen-autotools ought to go as a separate PR from the earlier items.

@ringlej
Copy link
Contributor Author

ringlej commented Nov 14, 2017

Would you be ok with one PR with each item as a separate self-contained commit? This would be easier, because each commit in the series will depend on changes made on earlier commits within the PR

@vlm
Copy link
Owner

vlm commented Nov 14, 2017

That would work as well.

Also, please make sure you rebase first. I just added a bunch of changes around fdeps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants