Use wikibase item ID first if available #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case this is used on a wikidata site, it should still use the WG_WIKIBASE_ITEM_ID of the current page if it is available. Otherwise, when viewing a regular wiki page hosted on Wikidata, and that page has a sitelink to an entity, the editor will attempt to use that page's name with the wbgetentity, and will obviously fail. In the future we may want to check if the page is in an entity namespace too, and fail otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case this is used on a wikidata site, it should still
use the WG_WIKIBASE_ITEM_ID of the current page if it is
available. Otherwise, when viewing a regular wiki page
hosted on Wikidata, and that page has a sitelink to
an entity, the editor will attempt to use that page's
name with the wbgetentity, and will obviously fail.
In the future we may want to check if the page is
in an entity namespace too, and fail otherwise.