Skip to content

Commit

Permalink
fix: remove empty implementation of TestStateListener from AbstractJD…
Browse files Browse the repository at this point in the history
…BCTestElement

TestStateListener + TestBean cause issues like in apache#6174,
so we should remove empty implementations
  • Loading branch information
vlsi committed Dec 19, 2023
1 parent e9c2ef9 commit 9c3c4bd
Showing 1 changed file with 1 addition and 38 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
import org.apache.jmeter.samplers.SampleResult;
import org.apache.jmeter.save.CSVSaveService;
import org.apache.jmeter.testelement.AbstractTestElement;
import org.apache.jmeter.testelement.TestStateListener;
import org.apache.jmeter.threads.JMeterVariables;
import org.apache.jmeter.util.JMeterUtils;
import org.slf4j.Logger;
Expand All @@ -57,7 +56,7 @@
* A base class for all JDBC test elements handling the basics of a SQL request.
*
*/
public abstract class AbstractJDBCTestElement extends AbstractTestElement implements TestStateListener{
public abstract class AbstractJDBCTestElement extends AbstractTestElement {
private static final long serialVersionUID = 235L;

private static final Logger log = LoggerFactory.getLogger(AbstractJDBCTestElement.class);
Expand Down Expand Up @@ -819,40 +818,4 @@ public String getResultVariable() {
public void setResultVariable(String resultVariable) {
this.resultVariable = resultVariable;
}


/**
* {@inheritDoc}
* @see org.apache.jmeter.testelement.TestStateListener#testStarted()
*/
@Override
public void testStarted() {
testStarted("");
}

/**
* {@inheritDoc}
* @see org.apache.jmeter.testelement.TestStateListener#testStarted(java.lang.String)
*/
@Override
public void testStarted(String host) {
}

/**
* {@inheritDoc}
* @see org.apache.jmeter.testelement.TestStateListener#testEnded()
*/
@Override
public void testEnded() {
testEnded("");
}

/**
* {@inheritDoc}
* @see org.apache.jmeter.testelement.TestStateListener#testEnded(java.lang.String)
*/
@Override
public void testEnded(String host) {
}

}

0 comments on commit 9c3c4bd

Please sign in to comment.