-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pitterling fix/aboutbox #100
Conversation
…o Pitterling-fix/aboutbox # Conflicts: # src/main/java/net/atomique/ksar/UI/AboutBox.java
omg .. should have had only the last 3 commits (not 8) ... dont know whats going on here .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CONTRIBUTORS.md formatting looks strange, however the PR looks fine otherwise
Apr 2016 pitterling - Peter Pitterling | ||
Nov 2016 vest | ||
Mar 2017 ikedaj - Junko IKEDA | ||
May 2017 elkrieg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above does not look like a markdown format.
At least GitHub renders it in a weird way: https://github.com/Pitterling/ksar/blob/f39cc47db31e0123a0fc2cd5ba1603ca9ddf80d1/CONTRIBUTORS.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like
* 2006-2010 xcherif - Alexandre Cherif
* 2006-2010 Max
...
would probably do
@Pitterling , the history in Pitterling-fix/aboutbox branch looks somewhat non-trivial.
That would produce a single commit on top of |
replacement for PR #79
fixes #76