Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pitterling fix/aboutbox #100

Closed
wants to merge 8 commits into from

Conversation

Pitterling
Copy link
Collaborator

replacement for PR #79
fixes #76

@Pitterling
Copy link
Collaborator Author

omg .. should have had only the last 3 commits (not 8) ... dont know whats going on here ..
@vlsi please check this PR

@Pitterling Pitterling requested a review from vlsi July 31, 2017 09:13
Copy link
Owner

@vlsi vlsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONTRIBUTORS.md formatting looks strange, however the PR looks fine otherwise

Apr 2016 pitterling - Peter Pitterling
Nov 2016 vest
Mar 2017 ikedaj - Junko IKEDA
May 2017 elkrieg
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above does not look like a markdown format.
At least GitHub renders it in a weird way: https://github.com/Pitterling/ksar/blob/f39cc47db31e0123a0fc2cd5ba1603ca9ddf80d1/CONTRIBUTORS.md

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like

* 2006-2010	xcherif 	- Alexandre Cherif
* 2006-2010   Max
...

would probably do

@vlsi
Copy link
Owner

vlsi commented Jul 31, 2017

@Pitterling , the history in Pitterling-fix/aboutbox branch looks somewhat non-trivial.
You can squash all the changes into a single commit like the following:

git fetch origin # just in case. By origin I mean vlsi/ksar repository
git checkout Pitterling-fix/aboutbox
git reset --soft origin/master
git commit -m "Update links in about box"

That would produce a single commit on top of origin/master.

@Pitterling Pitterling closed this Jul 31, 2017
@Pitterling Pitterling deleted the Pitterling-fix/aboutbox branch July 31, 2017 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About Box: showing outdated information
3 participants