Support adding earlier values after newer ones. #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
placed the setting and update of both values in the AllParser base class, because the code was duplicated between all individual parsers. Additionally, setting the startOfGraph to some earlier value was not implemented, while it could easily be supported.
|
Thanks, please fix the 3 checkstyle errors and i'm going to merge [ant:checkstyle] [ERROR] /home/travis/build/vlsi/ksar/src/main/java/net/atomique/ksar/AllParser.java:62: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/travis/build/vlsi/ksar/src/main/java/net/atomique/ksar/AllParser.java:63: At-clause should have a non-empty description. [NonEmptyAtclauseDescription]
[ant:checkstyle] [ERROR] /home/travis/build/vlsi/ksar/src/main/java/net/atomique/ksar/AllParser.java:81: 'method def modifier' have incorrect indentation level 0, expected level should be 2. |
ams-tschoening
added a commit
to ams-ts-ksar/ksar
that referenced
this pull request
Jun 6, 2018
|
Done, please review again. |
|
Thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
startofgraphandendofgraphwas duplicated between all parsers, so I centralized it in base classAllParsersand additionally renamed a bit to to better fit Java naming styles. Afterwards I was easily able to add that newer timestamps not only changeendofgraph, butstartofgraphas well, so one is able to add oldersarfiles to existing graphs. That didn't work before. Adding older data seems to have simply been ignored somewhere, OTOHAllParser.setDatehandled storing an earlier timestamp AND a later one already. So the implementation of both values is now in line.