Fix #174 compiler warnings + #172 addresses some LGTM alerts

src/main/java/net/atomique/ksar/SSHCommand.java

@@ -80,13 +80,12 @@ private void initComponents(JDialog dialog) {
     infopanel = new javax.swing.JPanel();
     hostnamePanel = new javax.swing.JPanel();
     HostnameLabel = new javax.swing.JLabel();
-    HostComboBox = new javax.swing.JComboBox();
-    passwordPanel = new javax.swing.JPanel();
+    HostComboBox = new javax.swing.JComboBox<>();
     PasswordLabel = new javax.swing.JLabel();
     PasswordField = new javax.swing.JPasswordField();
     commandPanel = new javax.swing.JPanel();
     ComboBoxLabel = new javax.swing.JLabel();
-    commandComboBox = new javax.swing.JComboBox();
+    commandComboBox = new javax.swing.JComboBox<>();
     buttonpanel = new javax.swing.JPanel();
     Cancelbutton = new javax.swing.JButton();
     ConnectionButton = new javax.swing.JButton();
@@ -488,21 +487,21 @@ public void showMessage(String message) {
   private javax.swing.JButton Cancelbutton;
   private javax.swing.JLabel ComboBoxLabel;
   private javax.swing.JButton ConnectionButton;
-  private javax.swing.JComboBox HostComboBox;
+  private javax.swing.JComboBox<String> HostComboBox;
   private javax.swing.JLabel HostnameLabel;
   private javax.swing.JPasswordField PasswordField;
   private javax.swing.JLabel PasswordLabel;
   private javax.swing.JPanel buttonpanel;
-  private javax.swing.JComboBox commandComboBox;
+  private javax.swing.JComboBox<String> commandComboBox;
   private javax.swing.JPanel commandPanel;
   private javax.swing.JPanel headerpanel;
   private javax.swing.JPanel hostnamePanel;
   private javax.swing.JPanel infopanel;
-  private javax.swing.JPanel passwordPanel;
+  private javax.swing.JPanel passwordPanel = new JPanel();
   private javax.swing.JLabel titleLabel;
   // End of variables declaration
-  private DefaultComboBoxModel userhostModel = new DefaultComboBoxModel();
-  private DefaultComboBoxModel commandModel = new DefaultComboBoxModel();
+  private DefaultComboBoxModel<String> userhostModel = new DefaultComboBoxModel<>();
+  private DefaultComboBoxModel<String> commandModel = new DefaultComboBoxModel<>();
   private String command;
   private kSar mysar;
   private JDialog dialog = new JDialog();

src/main/java/net/atomique/ksar/export/FileCSV.java

@@ -19,7 +19,6 @@
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Paths;
-import java.nio.file.StandardOpenOption;
 import java.time.LocalDateTime;
 import java.time.format.DateTimeFormatter;
 
@@ -86,7 +85,7 @@ private void export_treenode_header(SortedTreeNode node) {
     int num = node.getChildCount();
 
     if (num > 0) {
-/*    Object obj1 = node.getUserObject();
+      /*Object obj1 = node.getUserObject();
       if (obj1 instanceof ParentNodeInfo) {
         ParentNodeInfo tmpnode = (ParentNodeInfo) obj1;
         List nodeobj = tmpnode.getNode_object();
@@ -112,7 +111,7 @@ private void export_treenode_data(SortedTreeNode node, RegularTimePeriod time) {
     int num = node.getChildCount();
 
     if (num > 0) {
-/*    Object obj1 = node.getUserObject();
+      /*Object obj1 = node.getUserObject();
         if (obj1 instanceof ParentNodeInfo) {
         ParentNodeInfo tmpnode = (ParentNodeInfo) obj1;
         List nodeobj = tmpnode.getNode_object();

src/main/java/net/atomique/ksar/export/FilePDF.java

@@ -92,33 +92,38 @@ public void run() {
 
     try {
       writer = PdfWriter.getInstance(document, new FileOutputStream(pdffilename));
+
+      writer.setPageEvent(this);
+      writer.setCompressionLevel(0);
+
+      // document parameter before open
+      document.addTitle("kSar Grapher");
+      //document.addSubject("SAR Statistics of " + mysar.hostName);
+      //document.addKeywords("https://github.com/vlsi/ksar");
+      //document.addKeywords(mysar.hostName);
+      //document.addKeywords(mysar.myOS.sarStartDate);
+      //document.addKeywords(mysar.myOS.sarEndDate);
+      document.addCreator("kSar Version:" + VersionNumber.getVersionString());
+      document.addAuthor("https://github.com/vlsi/ksar");
+
+      // open the doc
+      document.open();
+      pdfcb = writer.getDirectContent();
+      PdfOutline root = pdfcb.getRootOutline();
+
+      IndexPage(document);
+
+      export_treenode(mysar.graphtree, root);
+
+      document.close();
+
     } catch (DocumentException | FileNotFoundException ex) {
-      log.error("Parser Exception", ex);
+      log.error("PDF creation Exception", ex);
+    } finally {
+      if (writer != null) {
+        writer.close();
+      }
     }
-    writer.setPageEvent(this);
-    writer.setCompressionLevel(0);
-
-    // document parameter before open
-    document.addTitle("kSar Grapher");
-    //document.addSubject("SAR Statistics of " + mysar.hostName);
-    //document.addKeywords("https://github.com/vlsi/ksar");
-    //document.addKeywords(mysar.hostName);
-    //document.addKeywords(mysar.myOS.sarStartDate);
-    //document.addKeywords(mysar.myOS.sarEndDate);
-    document.addCreator("kSar Version:" + VersionNumber.getVersionString());
-    document.addAuthor("https://github.com/vlsi/ksar");
-
-    // open the doc
-    document.open();
-    pdfcb = writer.getDirectContent();
-    PdfOutline root = pdfcb.getRootOutline();
-
-    IndexPage(document);
-
-    export_treenode(mysar.graphtree, root);
-
-    document.close();
-    writer.close();
 
     if (dialog != null) {
       dialog.dispose();

src/main/java/net/atomique/ksar/ui/Preferences.java

@@ -280,7 +280,7 @@ private void CancelButtonActionPerformed(
   private javax.swing.JSpinner jSpinner1;
   private javax.swing.JSpinner jSpinner2;
   // End of variables declaration//GEN-END:variables
-  DefaultComboBoxModel UI_lanf_model = new DefaultComboBoxModel();
+  DefaultComboBoxModel<String> UI_lanf_model = new DefaultComboBoxModel<>();
   DefaultComboBoxModel<String> PageFormatComboBox = new DefaultComboBoxModel<>();
   DefaultComboBoxModel<String> LinuxFormatComboModel = new DefaultComboBoxModel<>();
   SpinnerNumberModel imageWidthSpinner =