Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate from log4j2 to logback #266

Merged
merged 3 commits into from Jan 8, 2023
Merged

migrate from log4j2 to logback #266

merged 3 commits into from Jan 8, 2023

Conversation

Pitterling
Copy link
Collaborator

No description provided.

@Pitterling Pitterling added this to the 5.2.4 milestone Jan 7, 2023
@Pitterling Pitterling linked an issue Jan 7, 2023 that may be closed by this pull request
Logging - migrate from log4j to logback #263
Closed
@github-actions github-actions bot added the chore build configuration update label Jan 7, 2023
@Pitterling Pitterling requested a review from vlsi January 7, 2023 20:28
@Pitterling
Copy link
Collaborator Author

@vlsi please check why 'JDK8' is failing. Thx

@vlsi
Copy link
Owner

vlsi commented Jan 7, 2023

Thanks. I guess we can bump the minimal Java to 11 if you like. However, will check the failure tomorrow

@vlsi
Copy link
Owner

vlsi commented Jan 7, 2023

The failure is 'class file has wrong version 55.0, should be 52.0' which means logback is built for Java 11.

@Pitterling
Copy link
Collaborator Author

You are right .. https://logback.qos.ch/dependencies.html
Version 1.3 is made for Java8; 1.4 for Java11 .. both are feature identical .. i just need to pick the 1.3 version.

On the other side, i personally dont care if Java8 is still supported .. don't know how others are thinking about ..

@vlsi
Copy link
Owner

vlsi commented Jan 7, 2023

I guess moving to 11 minimum would ease these types of issues. I think 11 should be just fine from the users' point of view

@Pitterling
Copy link
Collaborator Author

Ok, but let's get 5.2.4 out first and target JDK11 for the next 6.0 release.

@Pitterling Pitterling merged commit 443aaa6 into vlsi:master Jan 8, 2023
@Pitterling Pitterling deleted the logback branch January 8, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlsi vlsi Awaiting requested review from vlsi

Assignees
No one assigned
Labels
chore build configuration update
Projects
None yet
Milestone
5.2.4
Development

Successfully merging this pull request may close these issues.

Logging - migrate from log4j to logback
2 participants
@Pitterling @vlsi