Improve the command line interface #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the original code, -help prints nothing. This change adjusts the log level. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Those who want to know the usage, just printing the usage is helpful. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
With the original code, -help prints the version information. Just printing the version information may not help the a person who wants to know about CLI usage of Ksar. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
improve-cli
branch
2 times, most recently
from
f1738a7
to
44ef54c
Compare
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
|
I added --help and -h options, doing the same as the -help option. |
|
Ping |
|
We have a long lasting issue for CLI.. the idea was to move it to something like picocli.. see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-inputoption is handy. However, the-helpoption doesn't work, so there is no way to know about it.I wonder whether we should use
Loggerto print the help message.System.out.print...orSystem.err.print...looks better to me.This is my first time writing a program in Java. I am not familiar with the conventions and culture of the language.
Anyway, better than nothing.