Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix align the page #61

Merged
merged 1 commit into from
Mar 6, 2017
Merged

Fix align the page #61

merged 1 commit into from
Mar 6, 2017

Conversation

ikedaj
Copy link
Contributor

@ikedaj ikedaj commented Mar 5, 2017

Fix right align the page number when exporting as pdf format.

@ikedaj
Copy link
Contributor Author

ikedaj commented Mar 5, 2017

By the way, it would be better if we can choose to insert/not insert the page number into PDF from "Options" -> "System preferences".
I tried to add the component, but it seems that "Form Editor" is needed.
Do you handle this?

https://github.com/vlsi/ksar/blob/master/src/main/java/net/atomique/ksar/UI/Preferences.java#L71

@Pitterling
Copy link
Collaborator

@ikedaj - same fix applies for rows 197 & 199. could you add this to your PR?

Regarding the changes to System Preferences: i believe no one from the maintainers uses Netbeans ...
Personally i never worked with the Forms Editor .. don't know how to handle this.

@ikedaj
Copy link
Contributor Author

ikedaj commented Mar 6, 2017

Thank you for pointing out that, I added those lines.
As for System Preferences, I'm not good at Netbeans, too...
I'll have to pass on that this time.

@Pitterling
Copy link
Collaborator

thx for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants