Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expectJSONTypes tests always passing? #16

Closed
frosty opened this issue Jan 7, 2013 · 3 comments
Closed

expectJSONTypes tests always passing? #16

frosty opened this issue Jan 7, 2013 · 3 comments

Comments

@frosty
Copy link

frosty commented Jan 7, 2013

I can't seem to get any expectJSONTypes tests to fail. As an example, I've used the Frisby Twitter example spec: https://github.com/vlucas/frisby/blob/master/examples/twitter_feed_spec.js

If I change, for example, retweeted: Boolean on line 22 to retweeted: Array, the spec still passes. The same goes for any type I choose. I would expect this test to fail if the value here is anything other than Boolean.

I've also tested this against the frisby_matchers_spec.js tests. As far as I can see it doesn't matter what I change the expectJSONTypes tests to check against, they never fail.

@tousdan
Copy link

tousdan commented Jan 7, 2013

It also does not seem to work with expectJSON.

@vlucas
Copy link
Owner

vlucas commented Jan 9, 2013

I am looking into this now. I am using Frisby in another project I am working on with the latest version, and these matchers are working as expected.

@vlucas
Copy link
Owner

vlucas commented Jan 15, 2013

Fixed in SHA1: 0789385

@vlucas vlucas closed this as completed Jan 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants