Fixes of issue #210 (_jsonParse leaks 'json' to the global scope) #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function _jsonParse leaks the variable json to the global scope because it is missing the var keyword. Robert Herhold holds the credit of this pull request
marcin-wosinek
added a commit
that referenced
this pull request
Jun 10, 2015
Fixes of issue #210 (_jsonParse leaks 'json' to the global scope)
|
Thanks a lot for the commit. We should have jshint for that kind of issue:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function _jsonParse leaks the variable json to the global scope because it is missing the var keyword. Robert Herhold holds the credit of this pull request