incrementAssertionCount throws exception "expect is not defined" #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 27, 2017 12:10
- If Frisby executed without Jasmine/Jest (e.g. using Gauge) incrementAssertionCount throws exception "expect is not defined".
H1Gdev
reviewed
Nov 27, 2017
src/frisby/expects.js
Outdated
| @@ -11,7 +11,7 @@ const utils = require('./utils'); | |||
| * Jasmine and others | |||
| */ | |||
| function incrementAssertionCount() { | |||
| if (_.isFunction(expect)) { | |||
| if (typeof expect != 'undefined' && _.isFunction(expect)) { | |||
There was a problem hiding this comment.
If expect is undefined then _.isFunction(expect) returns false.
https://lodash.com/docs/#isFunction
So, I think there is no effect.
In this issue, what is set for expect ?
There was a problem hiding this comment.
expect is not defined anywhere as there is no Jasmine. The issue is that it is not possible to call function with undefined variable as a parameter.
There was a problem hiding this comment.
@OrangeBean
Thanks. I understand.
use !== is more better.
|
Frisby is only officially supported with Jest, but the intent of the code here remains the same, so I just merged it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for issue #421
I'm using Frisby to test REST API. I'm replacing Jest with Gauge. It turns out Frisby throws exception if there is no Jasmine
expectdefined.