Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lint. #472

Merged
merged 3 commits into from May 15, 2018
Merged

Use lint. #472

merged 3 commits into from May 15, 2018

Conversation

H1Gdev
Copy link
Collaborator

@H1Gdev H1Gdev commented May 12, 2018

Add lint(use ESlint) to frisby.

  • Add ESLint.
  • Run ESlint on Travis CI.
  • Fix ESlint error.

@H1Gdev H1Gdev requested a review from vlucas May 12, 2018 08:21
@H1Gdev
Copy link
Collaborator Author

H1Gdev commented May 12, 2018

@vlucas

quote is excluded in this PR.

Which is appropriate for frisby ?

@vlucas
Copy link
Owner

vlucas commented May 14, 2018

I generally always use singlequotes.

@vlucas
Copy link
Owner

vlucas commented May 15, 2018

Thanks for this @H1Gdev. Long time overdue. I use ESLint in almost all my other projects. Not sure why it wasn't already in this one.

@vlucas vlucas merged commit 72721e8 into vlucas:master May 15, 2018
@H1Gdev H1Gdev deleted the lint branch May 16, 2018 00:03
@H1Gdev
Copy link
Collaborator Author

H1Gdev commented May 16, 2018

If there is a useful rule with frisby, let's add it as needed !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlucas vlucas Awaiting requested review from vlucas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@H1Gdev @vlucas