Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR4 Namespace & array of paths #16

Closed
wants to merge 1 commit into from
Closed

PSR4 Namespace & array of paths #16

wants to merge 1 commit into from

Conversation

stanlemon
Copy link
Contributor

This PR does two things...

  1. Switches over to psr4 and a namespace as @pmjones suggests in issue PSR-4 Compliance? #14
  2. Added the ability to pass an array of paths instead of just one, essentially enabling fallback overrides in env paths

@vlucas
Copy link
Owner

vlucas commented Feb 3, 2014

I actually want the namespace to be Dotenv, so the class would be Dotenv\Loader or something like that.

@pmjones
Copy link

pmjones commented Feb 3, 2014

/me nods

The only counter-argument I have is that there may be other Dotenv implementations out there, either now or later, who also name themselves "Dotenv." The top-level namespace needs to be a little more unique.

@vlucas
Copy link
Owner

vlucas commented Feb 3, 2014

I think that argument can be made for almost any package market, and is predominately a "first come, first served" basis.

@pmjones
Copy link

pmjones commented Feb 3, 2014

True. I would follow it up with the idea that you personally are probably above the hoi-polloi regarding this and other topics. ;-)

@stanlemon
Copy link
Contributor Author

I don't have a problem with Dotenv\Dotenv, if that's what you want to do I'll gladly update my PR. Let me know. Thanks.

@stanlemon stanlemon closed this Feb 5, 2014
@stanlemon
Copy link
Contributor Author

I'll resubmit for the namespace change without the array path change if you let me know what your preference is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants