New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Broken up the loader, and made load() return the actual environment variables #306

Merged
merged 2 commits into from Jan 2, 2019

Conversation

Projects
None yet
1 participant
@GrahamCampbell
Copy link
Collaborator

GrahamCampbell commented Jan 2, 2019

Loader was starting to do a lot of things, especially after adding multiline support, so I've pulled out parsing of the file into entries into one class (Lines), and handing the parsing of an entry in (Parser).

Finally, I've changed the load method so that it returns the actual environment variables as an associative array, rather than the raw lines from the file.

@GrahamCampbell GrahamCampbell merged commit 56ffd7b into vlucas:master Jan 2, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@GrahamCampbell GrahamCampbell deleted the GrahamCampbell:refactoring branch Jan 3, 2019

@GrahamCampbell GrahamCampbell changed the title Broken up the loader, and made load() return the actual environment variables [3.0] Broken up the loader, and made load() return the actual environment variables Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment