Custom callback validation against array

[ghost]

I have been trying to add a custom rule using "addRule" which uses an array as an extra parameter.

This is what I am validating with

$v->addRule('validNewsletter', array($this, 'validNewsletters'));
$valid_keys = array('news','sport');
$v->rule('validNewsletter', 'newsletters', $valid_keys)->message('Invalid newsletter selected.');

Unfortunately this currently breaks on line 611 of the Validator class

$label = isset($params[$k]) && isset($this->_labels[$params[$k]]) ? $this->_labels[$params[$k]] : $tag;

It complains that the isset value is not a string

Could this line be changed to this - which does work in this use case?

$label = isset($params[$k]) && !is_array($params[$k]) && isset($this->_labels[$params[$k]]) ? $this->_labels[$params[$k]] : $tag;

[ghost]

To get around it I have imploded the array when sending it to the callback and explode it in the callback to avoid the 'isset' error on line 611.

It might be worth documenting the callback method a bit more to mention this issue ?

[vlucas]

Looks like I will have to add some more tests around adding custom callbacks to debug this issue a bit more. Thanks for bringing this to my attention.

[ghost]

That would be good - I noticed there was no test for "addRule". It must be the only function without one :-)

I love the Validator btw

[vlucas]

I added a bunch of tests with this commit: 0f96c88, and I cannot reproduce this error. I also checked line 611, and the code is different for me on the current release than what you show. I just released v1.1.1 with the tests included. Please make sure you are up to date.

[ghost]

Ok thank you. I will update the package today and try it out.

[ghost]

@vlucas Yes I still get the error but it is line 615 now.

Illegal offset type in isset or empty

...\vendor\vlucas\valitron\src\Valitron\Validator.php:615
...\vendor\vlucas\valitron\src\Valitron\Validator.php:454
...\vendor\vlucas\valitron\src\Valitron\Validator.php:516
...

It happens when I pass an array as the third parameter of the rule. It looks like it is generating the error message and trying to use the third parameter to build the message?

[vlucas]

This test should cover your exact use case given the code you provided: 0f96c88 (line 576)

I cannot reproduce the error with it, and neither can Travis CI: https://travis-ci.org/vlucas/valitron/builds/9965676 - both PHP 5.3 and 5.4 pass all tests.

[vlucas]

I need you to clone Valitron, cd into the directory, and run phpunit and let me know what the output is. If all the tests pass, I need you to open a text editor, and add a new test that reproduces your error. Then show me that test here, and I will add it to the test suite to get this issue fixed once and for all (or preferably, just fork the project and submit a pull request with the test and the fix).

[ghost]

@vlucas Ok I can reproduce it now - it is when a specific label is added

    public function testAddRuleCallbackArrayWithArrayAsExtraParameterAndCustomMessageTwo()
    {
        $v = new Validator(array('name' => 'Chester Tester'));
        $v->labels(array('name' => 'Name'));
        $v->addRule('testRule', array($this, 'sampleObjectCallbackFalse'));
        $v->rule('testRule', 'name', array('foo', 'bar'))->message('Invalid name selected.');
        $this->assertFalse($v->validate());
    }

[vlucas]

Ah! So we were missing a labels call :). I will add this to the test suite and get a fix today.

[ghost]

excellent - thank you

[vlucas]

Just released v1.1.2 with a fix for your issue in it. Thanks again for taking the time to report this issue and help me investigate it.

https://github.com/vlucas/valitron/releases/tag/v1.1.2

[ghost]

Excellent, that worked for me perfectly now. Thanks for getting it in.