Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/config #28

Merged
merged 4 commits into from Nov 19, 2020
Merged

Feature/config #28

merged 4 commits into from Nov 19, 2020

Conversation

miljanic
Copy link
Contributor

Add possibility for user to define whether he wants an object or associative array returned from all api methods.
Defaults to current value false and returns object

Also lint all files.

@vluzrmos
Copy link
Owner

vluzrmos commented Dec 6, 2019

You only need to change 3 files: readme.md, config/slack-api.php and SlackApi/SlackApi.php.

@vluzrmos
Copy link
Owner

vluzrmos commented Dec 6, 2019

And thank you for the contribution!

@miljanic
Copy link
Contributor Author

@vluzrmos Not sure what you meant by only need to change 3 files? Should I undo the linting? Should I open another PR to lint all the files to some standard or you want them left untouched?
It's not a problem, I'm just not sure what did you mean exactly.
Thanks for response!

@vluzrmos vluzrmos merged commit e1e0512 into vluzrmos:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants