Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major change in a route not listed when impact filter is on #413

Closed
pyrog opened this issue Apr 23, 2024 · 2 comments
Closed

Major change in a route not listed when impact filter is on #413

pyrog opened this issue Apr 23, 2024 · 2 comments

Comments

@pyrog
Copy link

pyrog commented Apr 23, 2024

https://knooppuntnet.nl/en/analysis/route/13139760/changes

The topology of the route changed, one node was replaced, and by side effect, the name change.

Impact off: last version v6 is listed.
Capture d’écran 2024-04-23 à 10 10 05

Impact on: only the v1 is listed, but v6 is filtered 😢
Capture d’écran 2024-04-23 à 10 11 01

@vmarc
Copy link
Owner

vmarc commented Jun 12, 2024

The analysis logic can set two flags for a change:

  • happy
  • investigate

The happy flag is intended to indicate that the mapping quality has improved (for example: issues have been resolved, new nodes were added, etc.).

The investigate flag is intended to indicate that mapping quality may have become worse (for example: there are new facts, routes or nodes have been removed, etc.).

The impact filter looks for changes where at least one of these flags is set.

A route name change does not result in either the happy flag or the investigate flag to be set. The route quality is ok before the change, and is still ok after the change. So although a route name change may be experienced as a significant change, it is probably not really necessary to draw other mappers attention to it by setting the happy or investigate flag.

@vmarc vmarc closed this as completed Jun 12, 2024
@pyrog
Copy link
Author

pyrog commented Jun 13, 2024

In this case the geometry and topology got significant change: the beginning node was replaced by a completely different node (not an OSM node with the same name/ref near the previous node).

After Capture d’écran 2024-06-13 à 12 29 56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants