Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routeparam doing its job only when supposed to #7

Merged
merged 2 commits into from
Oct 29, 2017

Conversation

antonin-lebrard
Copy link
Contributor

the doclet handler of routeparam check now if it is doing its job when a @route tag is defined in the jsdoc comments it's working on.

@vmarchaud
Copy link
Owner

Thanks for taking the same to make this PR

@cravindra
Copy link

cravindra commented Dec 19, 2017

Hello. Can't find this change on the master branch. Is there something extra I need to do apart from the usual npm install --save-dev jsdoc-http-plugin?

@antonin-lebrard
Copy link
Contributor Author

@cravindra I see it on the master branch here: https://github.com/vmarchaud/jsdoc-http-plugin/commits/master
but the npm version is not automatically updated at each commit, so the changes might only appear when pulling directly from github and not from npm.

You could do this in your package.json to get the master branch in your node_modules:

  "jsdoc-http-plugin": "https://github.com/vmarchaud/jsdoc-http-plugin"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants