Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light Mode Support #49

Closed
Tamnac opened this issue Jan 18, 2024 · 5 comments · Fixed by #50
Closed

Light Mode Support #49

Tamnac opened this issue Jan 18, 2024 · 5 comments · Fixed by #50
Labels
enhancement New feature or request

Comments

@Tamnac
Copy link

Tamnac commented Jan 18, 2024

Currently the extensions seems to be focused on dark mode, resulting in very weird and impossible to read looks when using a light theme.

You can change the background color in settings, however manually changing that twice a day is bothersome, and that still leaves broken, illegible text.

Examples:

Light mode with dark background
image

Light mode with light background
image

@vmavromatis vmavromatis added the enhancement New feature or request label Jan 21, 2024
@heavyboots
Copy link

heavyboots commented Jan 24, 2024

For anyone changing this color a lot, I find "Navajo White" aka #FFDEAD to be both quite usable and memorable.

@vmavromatis
Copy link
Owner

Actually something weird on my setup (I doubt anyone else is using this)... I have this flag on chrome://flags/#enable-force-dark always. So using #FFDEAD this is what I see:

image

need to find a color which is usable for both light/dark theme and ideally also working for users with the chrome dark flag on... If no solution is found, I will stop using the flag and sacrifice myself for the greater good 🤷

@heavyboots
Copy link

Yeah it definitely works better on light themes. I think the only way we're ever going to see this work correctly is by having a separate default for light and dark themes. Since Lemmy can apparently detect what your browser is using and match it, I would think there must be some way to get that info and pick a selection color based on it. 🤔

@vmavromatis
Copy link
Owner

maybe with this

@vmavromatis
Copy link
Owner

vmavromatis commented Jan 26, 2024

I found a way to set the color based on theme selection, but seems it keeps getting overriden by localStorage

//Default bg color based on theme selection
if(document.getElementById("app").getAttribute("data-bs-theme")==="light"){
    var defaultTheme = "#FFDEAD"
  } else {
    defaultTheme = "#373737"
}

Maybe @InfinibyteF4 can do his magic ✨

Edit: fixed and opened a PR. @heavyboots if you wanna test try that with Tampermonkey or sth. Leaving the color field empty sets a default color which differs between dark/light.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants