Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 22 fix #23

Merged
merged 3 commits into from Oct 8, 2019
Merged

issue 22 fix #23

merged 3 commits into from Oct 8, 2019

Conversation

izhuravlev
Copy link
Contributor

Fixes: #22
I've added get_url_base, get_config_url and get_config_data functions.
For more information, see issue #22 comments

@mgax mgax added this to In Progress in vmck Oct 7, 2019
Copy link
Contributor

@Jokeswar Jokeswar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good 👍 , just some coding style issues.

interface/utils.py Outdated Show resolved Hide resolved
interface/utils.py Outdated Show resolved Hide resolved
interface/models.py Outdated Show resolved Hide resolved
interface/utils.py Outdated Show resolved Hide resolved
interface/utils.py Outdated Show resolved Hide resolved
interface/utils.py Outdated Show resolved Hide resolved
interface/utils.py Outdated Show resolved Hide resolved
@izhuravlev
Copy link
Contributor Author

Sure, will fix it right away!

@izhuravlev
Copy link
Contributor Author

@Jokeswar made requested corrections

interface/utils.py Show resolved Hide resolved
@Jokeswar Jokeswar merged commit 57e557d into vmck:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
vmck
  
In Progress (PRs)
Development

Successfully merging this pull request may close these issues.

Move regular expression separately
2 participants