Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unroll MIN as the straight ?: construct #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

yanick
Copy link

@yanick yanick commented May 26, 2013

Considering that not all compilers give us MIN implicitly, and since it's only at one place in the code, losing the MIN shouldn't be too high a price to pay, readability-wise, for portability.

Considering that not all compilers give us MIN implicitly,
and since it's only at one place in the code, losing the MIN
shouldn't be too high a price to pay, readability-wise, for
portability.
@christianbundy
Copy link

Just out of curiosity, which common compiler's don't give us MIN? I've been reading through the code in this repo and your PR sparked my interest. Thanks in advance!

@yanick
Copy link
Author

yanick commented Dec 3, 2013

Look at the failures of Escape::Houdini 0.1.2 (my Perl wrapper for the houdini lib) at http://www.cpantesters.org/distro/E/Escape-Houdini.html As usual, it's the windows compiler that seems to be causing problems, the naughty git. :-)

@christianbundy
Copy link

Thanks for the explanation! I'm going to maintain an updated fork of @vmg's project over at christianbundy/houdini, and I've merged your commit.

@yanick
Copy link
Author

yanick commented Dec 4, 2013

Sweet. The Perl module was using my own fork. I'm glad to ear I'll be able to just point to yours and have one less repo to worry about. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants