Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid escaping on HTML comments #272

Merged
merged 1 commit into from Jun 26, 2013
Merged

Avoid escaping on HTML comments #272

merged 1 commit into from Jun 26, 2013

Conversation

robin850
Copy link
Collaborator

Hello,

HTML comments opening and closing tags were previously escaped. This wasn't intended. This pull request fix this behavior.

Should resolve #268

HTML comments opening and closing tags were previously escaped. This
wasn't intended.

Fix issue #268
@mattr-
Copy link
Collaborator

mattr- commented Jun 26, 2013

👍 :shipit:

robin850 added a commit that referenced this pull request Jun 26, 2013
Avoid escaping on HTML comments
@robin850 robin850 merged commit 504bf0c into master Jun 26, 2013
@robin850 robin850 deleted the fix-escaped-comments branch June 26, 2013 16:28
@robin850
Copy link
Collaborator Author

@mattr- : Thanks for the quick feedback! ❤️ Would you mind have a look at #266 please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline HTML comments are not properly ignored, and instead is treated and escaped as text.
2 participants