Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Fix travis builds #651

Merged
merged 5 commits into from
Mar 7, 2018
Merged

[wip] Fix travis builds #651

merged 5 commits into from
Mar 7, 2018

Conversation

kolen
Copy link
Contributor

@kolen kolen commented Feb 28, 2018

Fix failing Travis builds

@kolen kolen changed the title Fix travis builds [wip] Fix travis builds Feb 28, 2018
@kolen kolen force-pushed the fix-travis-builds branch 3 times, most recently from 6c2f1f5 to ba154f3 Compare February 28, 2018 21:21
@kolen
Copy link
Contributor Author

kolen commented Mar 1, 2018

For some reason, require 'test/unit' in test_helper under Rubinius loads test-unit from standard lib (rubinius/3.99/codedb/source/rubysl/test/unit.rb), not from test-unit gem. Stdlib's Test::Unit delegates to minitest and breaks.

Stacktrace from my machine:

/usr/local/opt/rubinius/lib/rubinius/3.99/codedb/source/rubygems/core_ext/kernel_require.rb:135:in `require'
/usr/local/opt/rubinius/lib/rubinius/3.99/codedb/source/rubysl/test/unit/unit.rb:1:in `__script__'
/usr/local/opt/rubinius/lib/rubinius/3.99/codedb/source/rubygems/core_ext/kernel_require.rb:59:in `require'
/usr/local/opt/rubinius/lib/rubinius/3.99/codedb/source/rubysl/test/unit.rb:1:in `__script__'
/usr/local/opt/rubinius/lib/rubinius/3.99/codedb/source/rubygems/core_ext/kernel_require.rb:59:in `require'
/usr/local/opt/rubinius/lib/rubinius/3.99/codedb/source/test/unit.rb:1:in `__script__'
/usr/local/opt/rubinius/lib/rubinius/3.99/codedb/source/rubygems/core_ext/kernel_require.rb:59:in `require'
/Users/kolen/items/redcarpet/test/test_helper.rb:5:in `__script__'
/usr/local/opt/rubinius/lib/rubinius/3.99/codedb/source/rubygems/core_ext/kernel_require.rb:59:in `require'
/Users/kolen/items/redcarpet/test/custom_render_test.rb:2:in `__script__'
/usr/local/opt/rubinius/lib/rubinius/3.99/codedb/source/rubygems/core_ext/kernel_require.rb:59:in `require'
/usr/local/opt/rubinius/lib/rubinius/3.99/gems/gems/rake-12.2.1/lib/rake/rake_test_loader.rb:17:in `__script__'
/usr/local/opt/rubinius/lib/rubinius/3.99/gems/gems/rake-12.2.1/lib/rake/rake_test_loader.rb:5:in `__script__'

It loads rubinius/3.99/codedb/source/test/unit.rb which contains single line:

require "rubysl/test/unit"

In load path, rubinius/3.99/gems/gems/test-unit-3.2.7/lib is before rubinius/lib/rubinius/3.99/codedb/source.

@kolen
Copy link
Contributor Author

kolen commented Mar 3, 2018

Maybe we should allow ruby-head to fail? It's unstable version and it depends on time when build started (it takes latest commit, not fixed version).

matrix:
  allow_failures:
  - rvm: ruby-head

(Also AFAIK rvm can install head version of rbx too, we can try to build against it but allow for failure)

@mattr-
Copy link
Collaborator

mattr- commented Mar 5, 2018

Maybe we should allow ruby-head to fail?

we should definitely allow ruby-head to fail.

@kolen
Copy link
Contributor Author

kolen commented Mar 5, 2018

Made ruby-head allowed to fail. Now tests pass on CI. That error is still there in current head version (BTW, tests pass on my machine on ruby-head).

(Also AFAIK rvm can install head version of rbx too, we can try to build against it but allow for failure)

Seems that it is not available on Travis so I didn't add rbx-head (it requires building from sources non-standard way).

@mattr-
Copy link
Collaborator

mattr- commented Mar 7, 2018

🙌 Thanks for fixing this!

@mattr- mattr- merged commit f4bd88b into vmg:master Mar 7, 2018
@kolen kolen deleted the fix-travis-builds branch March 7, 2018 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants