Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally decode nil-values #30

Closed
wants to merge 1 commit into from
Closed

Conditionally decode nil-values #30

wants to merge 1 commit into from

Conversation

dim
Copy link
Contributor

@dim dim commented Apr 10, 2015

So here is an alternative approach to #25 with an extended test. Your approach in #26 wouldn't work for that test.

@vmihailenco
Copy link
Owner

I still prefer you original PR #23. Let me clean it and resend.

Also please don't use msgpack.Register. Marshal/Unmarshal interface is more idiomatic way to support custom encoding.

@dim
Copy link
Contributor Author

dim commented Apr 10, 2015

I still prefer you original PR #23. Let me clean it and resend.

Not sure it was such a good idea really. I went over the use cases and there's no real need for all that extra logic, plus it makes the client code really messy. The only 'feature' that is really required is the ability for a client to PeekNil

Also please don't use msgpack.Register. Marshal/Unmarshal interface is more idiomatic way to support custom encoding.

I wish I could, but there's #32

@vmihailenco
Copy link
Owner

This was addressed in another PR. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants