-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] Add sleep blocks manually and improve editing #373
Comments
What would be the UI for the first point? Perhaps a new menu item, so you don't need to do start + stop + tap on the sleep item + tap on the start/end widgets manually? |
Not sure. Would a second button next to Start be against design guidelines ? I've seen other apps have multiple buttons in the lower right corner but IIRC it is usually subordinated to a main action, i.e. secondary functions are accessed in some way, after activating the only button being displayed. Hopefully this is clear enough; should you need an example, in AntennaPod activate Multi Select, this will show a button similar to the Start button in plees, which, when pressed, brings up multiple subordinate options. If the second button is a no-no, then perhaps use tap'n'hold ? However, you would need a cue to inform the user that the button has a secondary function. |
As far as improved editing is concerned, I just finished implementing a small change. Basically it splits up date and time into two distinct fields in the sleep activity. There is a listener on each of the 4 resulting fields (start date, start time, end date, end time) opening only datepicker / timepicker, not both sequentially. Tested on my phone and works. Had trouble setting up the project correctly in IDEA, so code formatting would probably need to be done somehow. Could not figure out how to do it without IDE. Should I open a pull request for my change? |
Please do :) If you push your changes to your fork, you'll get a URL to create the PR, it's nothing complex. If that would be unclear, just ask. Thanks! |
Fixes <vmiklos#373>. Change-Id: I4762d9f35191faf5d8a6601d695f6f38185f3de0
Let's focus on the improved editing in this issue, the rest can be a new issue if there is still demand for it. |
Fixes <#373>. Change-Id: I4762d9f35191faf5d8a6601d695f6f38185f3de0
Fixes <#373>. Change-Id: I4762d9f35191faf5d8a6601d695f6f38185f3de0
To be clear, IMO plees doesn't currently clear a very low usefulness bar for usage. I appreciate that it is supposed to be a minimalist app, however if it fails to cater to basic tasks in a straightforward fashion, it's unlikely folks are heading to github en masse to argue in favor of features, most likely because they will have uninstalled the app after 5 minutes. And given the dearth of FOSS sleep trackers that'd be a pity. |
Currently adding a sleep block after the fact (i.e. without triggering the sleep tracker manually when you fall asleep) involves starting and stopping the timer and editing the start/finish time manually.
All of this is very cumbersome whenever the user forgets to activate the tracker or simply falls asleep wherever (train, couch, you pick it)
My suggestions would be:
The text was updated successfully, but these errors were encountered: