Validate params with help of a instance var to be able to

render the show template with the submitted result
vmoravec · Dec 20, 2012 · 598e1d9 · 598e1d9
1 parent eb6ccdb
commit 598e1d9
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/plugins/mailsetting/app/controllers/mailsetting_controller.rb b/plugins/mailsetting/app/controllers/mailsetting_controller.rb
@@ -57,9 +57,9 @@ def show
   def update
     authorize! :write, Mailsetting
     mail_params = params['mailsetting'] || params['mail'] #keep mail for backwards compatibility with old REST API
-    new_settings = Mailsetting.new mail_params
+    @mail = Mailsetting.new mail_params
-    unless new_settings.valid?
+    unless @mail.valid?
-      problem _(new_settings.errors.full_messages.join(', '))
+      problem _(@mail.errors.full_messages.join(', '))
       return
     end
 
@@ -117,7 +117,7 @@ def create
   def problem message
     if request.format.html?
       flash[:error] = message
-      redirect_to :action => "show"
+      render :action => "show"
     else #REST request
       error = { "error" => { "type" => "ADMINISTRATOR_ERROR", "messsage" => message, "id" => "ADMINISTRATOR" }}
       respond_to do |format|