Fix memory leaks #43
Merged
Fix memory leaks #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Promisifying this element causes a memory leak where every time a chart is created a number of evaled source code strings are held in memory and never released.
Calling the `destroy()` function is necessary to prevent a memory leak as otherwise the chart.js core code maintains references to every chart ever generated with this library. The `instances` variable it assigns references to, seen [here](https://github.com/chartjs/Chart.js/blob/master/src/core/core.controller.js#L105), is only ever cleared upon calling of the `destroy` function. It's not attached to any part of the DOM and therefore is not cleaned up by the destruction of the virtual DOM; it's a package-level variable that persists across all runs of the chart.js library.
|
@moberemk seems OK to me. thanks for the PR! |
|
Glad I could help, hope you can put it out to NPM soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this library on our server we started running in to memory leaks past a certain scale; I believe I've identified the issues causing this memory leak and have a patch here to fix them, see commit comments for full details on the changes made and the rationale.
Should close #30