Make check for sudo privileges more accurate #375
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing method of checking if the Gravity Sync user has sudo rights is flawed, in that it will break if the user is not in the
sudo
group (on Debian based distros) or thewheel
group (on CentOS/RHEL distros).A more accurate way of checking if a user has sudo privileges is using
sudo --validate
orsudo -n true
; both of which return0
if the user has sudo privileges.This commit updates the
validate_sudo_status
function to usesudo --validate
so that Gravity Sync is actually checking if a user has sudo privileges, rather than just checking group memberships.