Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loopnz should be loopne #20

Closed
ghghost opened this issue Apr 24, 2013 · 4 comments
Closed

loopnz should be loopne #20

ghghost opened this issue Apr 24, 2013 · 4 comments

Comments

@ghghost
Copy link
Contributor

ghghost commented Apr 24, 2013

For consistency with repne.

@mgpleszkoch
Copy link

And also for consistency with loope.

@mgpleszkoch
Copy link

While we're at it, how about changing pusha to pushaw, and popa to popaw, so that they mirror the pushfw, pushfd, popfw, and popfd instructions.

@ghghost
Copy link
Contributor Author

ghghost commented Apr 24, 2013

The Intel 16-bit mnemonics are simply pusha, popa, pushf, popf. I suggest changing pushfw and popfw to pushf and popf, since udis86 generally follows the Intel mnemonics.

@ghghost
Copy link
Contributor Author

ghghost commented Apr 25, 2013

This is included in issue #17, and is fixed by the fix for that issue.

@ghghost ghghost closed this as completed Apr 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants