Alternate more centerline derivatives #105
Conversation
chir-set
force-pushed
the
MoreCenterlineDerivatives_2
branch
from
99f1aac
to
60f3518
Compare
chir-set
force-pushed
the
MoreCenterlineDerivatives_2
branch
from
60f3518
to
d3126a0
Compare
| # in batch mode, without a graphical user interface. | ||
| self.logic = CenterlineDisassemblyLogic() | ||
|
|
||
| self.ui.componentComboBox.addItem("Bifurcations", 1) |
There was a problem hiding this comment.
use constant instead of magic number (1, 2, 3)
| self._parameterNode.disconnectGui(self._parameterNodeGuiTag) | ||
| self._parameterNodeGuiTag = None | ||
|
|
||
| def onSceneStartClose(self, caller, event) -> None: |
There was a problem hiding this comment.
Have you tried to use the new module template (in Slicer-5.6.1)?
The parameter node wrapper is a bit more opaque, but it would reduce the amount of boilerplate code you need to add and maintain.
| # in batch mode, without a graphical user interface. | ||
| self.logic = CenterlineDisassemblyLogic() | ||
|
|
||
| self.ui.componentComboBox.addItem("Bifurcations", 1) |
There was a problem hiding this comment.
Make it translatable - _("Bifurcation")
Docs/CenterlineDisassembly.md
Outdated
|
|
||
| ### Disclaimer | ||
|
|
||
| Use at your own risks. |
There was a problem hiding this comment.
This is true for the entire 3D Slicer application and all modules in all extensions. If you really want then you can remind people in the extension's documentation. So, I would only add a warning for a specific module if there is something unusual about this module or you have somet more specific information/advice than just "use at your own risks".
|
I'll handle all your suggestions in the coming days. As for the new module template wizard, I suppose you are hinting at the older modules, like Cross-section analysis. I'll update them in the coming weeks as it will take more time. The new parameter node wrapper is indeed more friendly. Thank your for your comments. |
This module breaks down a bifurcated centerline model into parts. Incidentally, improve the indentation of the main README file.
A crash would occur on a simple call while using vtkSetStringMacro.
Ex:
l = slicer.modules.branchclipper.logic()
l.SetCenterlineRadiusArrayName("r")
Using vtkSetMacro with std::string instead.
Branch profiles are created as models. The module may create branch surfaces as segments and/or branch profiles.
chir-set
force-pushed
the
MoreCenterlineDerivatives_2
branch
from
d3126a0
to
62801d6
Compare
This PR proposes one new module dealing with centerline models, and extends the functionalities of the 'BranchClipper' module.
CenterlineDisassembly: it breaks down a bifurcated centerline model into parts,
BranchClipper: highlight bifurcation splitting lines.
Incidentally,
Please consider for inclusion in SlicerVMTK, as an alternative to #104 .
Regards.