Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make most modules translatable #108

Merged
merged 11 commits into from Feb 25, 2024
Merged

Make most modules translatable #108

merged 11 commits into from Feb 25, 2024

Conversation

chir-set
Copy link
Collaborator

Hi @lassoan, @pieper,

This PR is intended to make most modules of SlicerVMTK translatable. It is based on branch 'ParameterNodeWrapperAndOther' which is in PR #107, and not on the 'master' branch.

The modifications follow this discussion and the link to the translation guide.

I don't claim this PR is 100% fit for a merge. Please advise about required improvements.

@lassoan, please note I have felt free to modify 'ExtractCenterline' module also in 2c40a32. This patch can be easily dropped if you deem it necessary.

This PR is intended to be merged in 'Rebase and merge' mode. If PR #107 is not accepted for a merge, I can still modify this PR to rebase it on 'master'.

Your comments are welcome.

Regards.

@pieper
Copy link
Member

pieper commented Jan 29, 2024

Thanks for working on this @chir-set 🙏

@lassoan probably this is easiest to test by merging and looking on various computers, do you agree? Or maybe you would rather read through the changes first.

@chir-set
Copy link
Collaborator Author

Hi @lassoan ,

Following your comment here, what would you/I do with this PR?

Thank you for a follow-up.

Copy link
Contributor

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you. I'll create the translation component on weblate and then translations can be submitted there.

@lassoan lassoan merged commit fd28743 into vmtk:master Feb 25, 2024
@chir-set chir-set deleted the Translatable branch February 25, 2024 15:48
@chir-set
Copy link
Collaborator Author

chir-set commented Feb 25, 2024

Thanks for the merge @lassoan.

I translated an easy one in French for a first experience, ArterialCalcificationPreProcessor namely. I have no idea what happens next, how and when it is included at runtime. Please inform briefly. I can continue later on without any hurry.

Regards.

@lassoan
Copy link
Contributor

lassoan commented Feb 26, 2024

You can now install the LanguagePacks extension, download translations, and select the application language. See https://github.com/Slicer/SlicerLanguagePacks/blob/main/HowToUse_fr.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants