[WIP] Pypes Refactor #273
Open
[WIP] Pypes Refactor #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was necessary to do because of character encoding differences in python 2 and 3. Since we were note defining an explicit encoding, we were getting odd "non-ascii-character" errors in python 2. See PEP 263 https://www.python.org/dev/peps/pep-0263/ for more info.
This attempts to clarify and optomize the behavior of the pypes module. The previous method (using exec to import * from a module) is considered to be extremly sinful and risky. This should achieve the same purpose while preventing duplicate imports and non-necessary namespace creation.
… second pass through at refactoring
[WIP] PypeS Refactor & Documentation
Cleanup Package Structure and Import Handling
…upport since the simplenamespace object is not included
Integrate changes from master into develop-pypes branch
work on increasing test coverage of pypes module
|
@daron1337 this is the PR which needs review. I will fix the conflicts this weekend. Thank you! |
rlizzo
commented
Jul 27, 2018
rlizzo
commented
Jul 27, 2018
rlizzo
commented
Jul 27, 2018
rlizzo
commented
Jul 27, 2018
| @@ -29,12 +29,14 @@ vmtk is cross-platform and will compile and work on Linux, Mac OSX and Windows. | |||
|
|
|||
| In order to successfully compile and use vmtk, the following software has to be installed in your system: | |||
| - [Git](www.git-scm.org) (>= 1.6) | |||
| - [Python](www.python.org) (2.7, 3.5+) | |||
| - [Python](www.python.org) (3.5+) | |||
rlizzo
commented
Jul 27, 2018
rlizzo
commented
Jul 27, 2018
rlizzo
commented
Jul 27, 2018
rlizzo
commented
Jul 27, 2018
rlizzo
commented
Jul 27, 2018
rlizzo
commented
Jul 27, 2018
rlizzo
commented
Jul 27, 2018
rlizzo
commented
Jul 27, 2018
rlizzo
commented
Jul 27, 2018
rlizzo
commented
Jul 27, 2018
rlizzo
commented
Jul 27, 2018
|
@kayarre what do you think about this PR? |
|
Thank you @lassoan. I will look at this within this week and dig around. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am creating this PR in order to centralize conversation around the proposed changes to the Pypes Modeule, Jupyter Notebook Integration, and the general package structure layout.
At the time of writing, the
develop-pypesbranch is composed of #272 #271 #268.More information to follow.