Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Clear system properties in SecurityUtilsTest #319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lzx404243
Copy link

The tests com.vmware.admiral.common.util.SecurityUtilsTest.testEnsureTrustStoreSettings and com.vmware.admiral.common.util.SecurityUtilsTest.testEnsureTlsDisabledAlgorithms are not idempotent and fail if run twice in the same JVM, because each of the tests pollutes some states(system properties) shared among tests. It may be good to clean this state pollution so that some other tests do not fail in the future due to the shared state polluted by this test.

The suggested fix to clear the system properties that are set in the tests when each test finishes.

With the proposed fix, the test does not pollute the shared state (and passes when run twice in the same JVM).

@vmwclabot
Copy link

@lzx404243, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link

@lzx404243, VMware has approved your signed contributor license agreement.

@lzx404243
Copy link
Author

Can someone please review this? Any feedback on the changes would be greatly appreciated. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants