Skip to content
This repository has been archived by the owner on Mar 24, 2022. It is now read-only.

Remove race condition in resource test. #13

Closed
wants to merge 1 commit into from
Closed

Remove race condition in resource test. #13

wants to merge 1 commit into from

Conversation

robdimsdale
Copy link
Contributor

Fixes #12

I know the race condition was only in test code, but it was still cluttering up the test output.

We could do something more intelligent with channels/mutex if the data really did need to be read across multiple go routines, but I think in this case it's not necessary. I accept it's slightly annoying to not have the exit code declared or defined alongside other related variables anymore.

Open to suggestions as to other ways to fix this.

@vito
Copy link
Contributor

vito commented May 3, 2015

I think this is actually from the tests not properly waiting for the example's process to exit afterwards. I'll do a commit to fix it that way. Thanks for pointing this out; I thought we were running with -race in CI this whole time, but I guess not. Fixing that too.

@vito vito closed this May 3, 2015
@robdimsdale robdimsdale deleted the fix-tests-race-conditition branch May 3, 2015 20:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ginkgo -r -race results in data race in resource suite
2 participants