Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

[UI] fix build for 0.12 where relative paths cause issues for theming #2336

Merged
merged 1 commit into from Jun 6, 2018

Conversation

gnomeontherun
Copy link
Contributor

Using relative links to node_modules in our build works fine for our build, but if someone tries to build a theme and imports our file, the file paths are no longer correct. We had the tilde importer in the past, but it doesn't seem to work the same without additional webpack functionality. This will require anyone building a custom theme to add the --include-path=node_modules to their build as well, or if they are using the Angular CLI they can add the following in angular.json to the build.options object (next to styles).

            "stylePreprocessorOptions": {
              "includePaths": [
                "node_modules"
              ]
            },

Fixes #2330

Using relative links to node_modules in our build works fine for our build, but if someone tries to build a theme and imports our file, the file paths are no longer correct. We had the tilde importer in the past, but it doesn't seem to work the same without additional webpack functionality. This will require anyone building a custom theme to add the `--include-path=node_modules` to their build as well.

Signed-off-by: Jeremy Wilken <gnomation@gnomeontherun.com>
@gnomeontherun gnomeontherun merged commit becc8eb into vmware-archive:master Jun 6, 2018
@gnomeontherun gnomeontherun deleted the v0.12-theming branch June 6, 2018 18:45
@adibwoy adibwoy removed the In Review label Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants