fix: adding .js extension to exported *.css.js file #4364
Conversation
• this was throwing off some versions/configurations of Jest • the module loader was looking for a CSS file Signed-off-by: Scott Mathis <smathis@vmware.com>
| @@ -24,4 +24,4 @@ export * from './mixins/css-helpers'; | |||
| export * from './mixins/unique-id'; | |||
| export * from './mixins/apply-mixins'; | |||
| export * from './interfaces'; | |||
| export { styles as baseStyles } from './base/base.element.css'; | |||
| export { styles as baseStyles } from './base/base.element.css.js'; | |||
There was a problem hiding this comment.
This will fix the issue temporarily for Jest but once we pull Core components into clr-angular it will break again. We should update all the relative import paths in core to have .js at the end like this one. This is a fundamental issue with TypeScripts output not including the .js file extension. See discussion here microsoft/TypeScript#16577
You can see here lit-html and lit-element do the same thing to get around this issue.
https://github.com/Polymer/lit-element/blob/master/src/lit-element.ts#L18
This would make this a pretty large PR so we can merge this to fix the Jest issue now and I can open a new issue describing the steps to address the rest or we tackle this now in this PR. Either way is fine.
There was a problem hiding this comment.
I approve but request a backlog ticket to be opened for https://github.com/vmware/clarity/pull/4364/files#r391847610
|
@gnomeontherun |
mathisscott
added
@cds/core
resolution: fixed
type: build
• this was throwing off some versions/configurations of Jest
• the module loader was looking for a CSS file
Signed-off-by: Scott Mathis smathis@vmware.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We have to export the base element styles. These are generated
*.css.jsstyles.Some configs/implementations of Jest don't try to look for
*css.js. They stop looking at*.css.Issue Number: N/A
What is the new behavior?
I added the full path. This is the only Clarity issue I've been able to find that impedes Jest configuration. Every other issue in #4094 and #4196 are (thus far) solvable by properly configuring an application.
Does this PR introduce a breaking change?
Other information