Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

fix: contrast colors #6747

Merged
merged 1 commit into from
Mar 8, 2022
Merged

fix: contrast colors #6747

merged 1 commit into from
Mar 8, 2022

Conversation

coryrylan
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • clarity.design website / infrastructure changes
  • Other... Please describe:

What is the new behavior?

Fixes a few minor contrast issues within clr-angular + core shim. Aligns the colors to work better together with the card button and a bug with the disabled button state. Will back port to v5 as well.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coryrylan coryrylan self-assigned this Mar 8, 2022
@coryrylan
fix(core): contrast colors
89d5e11 
- fix shim alignment colors with button/card for clr-angular compat

Signed-off-by: Cory Rylan <splintercode.cb@gmail.com>
@coryrylan coryrylan merged commit fee9c1b into next Mar 8, 2022
@ashleyryan ashleyryan mentioned this pull request Jun 9, 2022
Merged
14 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hippee-lee hippee-lee hippee-lee approved these changes

@mathisscott mathisscott mathisscott approved these changes

Assignees

@coryrylan coryrylan

Labels
@cds/core @clr/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coryrylan @hippee-lee @mathisscott