Update install.sh to work with FreeBSD cloud-init

[dariakts]

Hello,

Here's an update to install.sh script so it would work correctly with FreeBSD (cloud-init configurations are in /usr/local/etc/cloud on FreeBSD).

[akutz]

Hi @dariakts,

Thank you so much for the PR! I posted a few comments -- primarily picking of nits. I also suggest using http://shellcheck.net to validate the changes prior to submitting changes to shell scripts. Thanks!

[dariakts]

Thank you for the reply!

I've made some updates as you suggested. I've also replaced double equals by simple equals as suggested by http://shellcheck.net.

# Configure path for cloud-init configuration
if [ "$(uname)" = "Linux" ]; then
  CLOUD_CONFIG_DIR=/etc/cloud
elif [ "$(uname)" = "FreeBSD" ]; then
  CLOUD_CONFIG_DIR=/usr/local/etc/cloud
else
  echo "unknown os" 1>&2 && exit 1
fi

What do you think about it ?

[akutz]

Thank you for the reply!

I've made some updates as you suggested. I've also replaced double equals by simple equals as suggested by http://shellcheck.net.

# Configure path for cloud-init configuration
if [ "$(uname)" = "Linux" ]; then
  CLOUD_CONFIG_DIR=/etc/cloud
elif [ "$(uname)" = "FreeBSD" ]; then
  CLOUD_CONFIG_DIR=/usr/local/etc/cloud
else
  echo "unknown os" 1>&2 && exit 1
fi

What do you think about it ?

Hi @dariakts,

I really appreciate you taking the time to address the feedback. I've got several more ideas, but this works as is, and that's fine for now. Please go ahead and squash your last commit into your first. Once you do that I will merge the PR. Thanks!

[dariakts]

Hello,

It's done @akutz :)

[akutz]

Hi @dariakts,

Somehow I missed the update that got back to this. Do you mind fixing the conflict? Once it is, I will happily merge this!

[akutz]

This issue is being closed because this datasource has been merged into cloud-init (canonical/cloud-init#953):

Component	Source	Tests
Datasource	DataSourceVMware.py	test_vmware.py
Identification	ds-identify	test_ds_identify.py
Documentation	vmware.rst

In order to participate in the growth of this datasource moving forward, please:

• Ask a question in the #cloud-init IRC channel on Libera
• Search the cloud-init mailing list archive
• Join the cloud-init mailing list
• Report issues with Launchpad

Once again, many thanks to the wonderful community that has grown around this datasource, and I look forward to seeing everyone in the new cloud-init forums!