WIP: API specification for Column REST service #20
base: master
Are you sure you want to change the base?
Conversation
@kars7e, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
options: | ||
type: "object" | ||
$ref: '#/definitions/Options' | ||
extra_vars: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is extra_vars out of 'options' ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i didn't find the ssh_extra_args, scp_extra_args, sftp_extra_args and ssh_common_args in the swager file.
- http | ||
basePath: /v1 | ||
paths: | ||
/tasks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "tasks" might be confused with Ansible tasks in a playbook. Rather some other noun not already used such as "job", "run", etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, 'run' would be better.
I will pushed a scratch patch by using flask api.
info: | ||
description: Column - Ansible as a service | ||
title: Column | ||
version: 0.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be a separate version from column version?
type: array | ||
skip_tags: | ||
type: array | ||
susbset: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be subset
get: | ||
summary: "Retrieve Task by its ID" | ||
description: "Returns single task given its ID" | ||
operationID: "getTaskByID" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some parameters are using camelcase others using underscore (playbook_path)
This WIP for API specification for column REST service. all comments & feedback welcome!
This change is